-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin VW, Gensim, and Scikit-learn versions #317
Pin VW, Gensim, and Scikit-learn versions #317
Conversation
I think we should pin fastText too, to the current version ( Unfortunately #292 is stuck currently due to a bug in the new fastText Python bindings. When we get around to merging that we should then update the pin to the new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
The pinned versions should probably be specified in setup.py
too. For example, pip install annif[vw]
should install VW 8.7, not some other version.
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 55 55
Lines 2867 2867
=======================================
Hits 2849 2849
Misses 18 18 Continue to review full report at Codecov.
|
Also pinned versions in Wiki page for fasttext and VW installation with |
Pin versions:
At the moment fasttext(mirror) is not pinned, maybe wait for resolving #290 by merging PR #292?
Closes #291.